Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KMeansSummarizer broken on normal usage #59

Closed
askarbozcan opened this issue Aug 14, 2020 · 0 comments
Closed

KMeansSummarizer broken on normal usage #59

askarbozcan opened this issue Aug 14, 2020 · 0 comments

Comments

@askarbozcan
Copy link
Member

KMeansSummarizer's .predict() accepts only Doc object, however when using KMeans normally (aka with __ call __), ExtractiveSummarizer gets Doc's sentences first and passes those to predict, which breaks KMeans when used to summarize and not to score.
husnusensoy added a commit that referenced this issue Aug 15, 2020
@husnusensoy
Standardize summarizer [resolves: #59]
2b7c0ce 
    We have significantly standardized our summarizers (specifically
    cluster based ones)

    Summarizers now allow following parameter types on `predict` and
    `__call__` functions:
      Doc
      List[Sentences]
      List[str] (each element is taken as a sentence)

    Reference [commit: 8b1cfe8]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@askarbozcan