Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pytest upgrade from pytest 3 to pytest 6 #3

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

tking16
Copy link
Collaborator

@tking16 tking16 commented Aug 10, 2020

No description provided.

Copy link
Member

@Chisnet Chisnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of relatively minor comments

Given this is public it might also be worth:

  • Tagging the current version in git
  • Updating the version number for this new version and tagging it

**/.vscode

.pytest_appium.egg-info
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can probably just make this *.egg-info tbh

def get_json(url):
return _decode_response(urllib.request.urlopen(url))
def get_json(url, headers: dict=None):
r = requests.get(url, headers=headers)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for not also updating the post if we're swapping urlib for requests?

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔍 Ready for Review Pull Request is not reviewed yet
2 participants