Windows fixes #72
Merged
Windows fixes #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way the game can compile on other compilers like Clang, MSVC, Intel, etc.
Visual Studio's compiler, cl.exe, generates slightly different mangled names for `struct Foo` and `class Foo`, causing linker errors.
Visual Studio gets confused by `__attribute__((noreturn))`.
fseek() was crashing with invalid argument. The FILE* couldn't be passed from Globulation 2 to the vorbisfile library because vorbisfile and globulation 2 were linked to different versions of the C runtime.
On 64-bit Windows, DWORD_PTR and DWORD are different sizes, and this causes an error with GCC 12 on MSYS2 Mingw64 on Windows 10.
Quipyowert2
force-pushed
the
windows-fixes
branch
from
34b9bca
to
dfe45c5
Compare
|
Oops, I accidentally left the variable length array commit in there by mistake. That commit tried to fix the VLA error in Visual Studio but made the declaration much uglier. |
This was referenced Apr 10, 2023
|
Looks good to me, merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has some changes that made the code work better with Visual Studio and refactor some code that uses non-standard stuff like private GCC namespaces and
__attribute__. Also, there is a workaround for microsoft/vcpkg#2292 included.I'll make a separate pull request for the VS project files.