Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert notes feature from 3.0 release #1045

Closed
ocean90 opened this issue Apr 11, 2020 · 0 comments · Fixed by #1046
Closed

Revert notes feature from 3.0 release #1045

ocean90 opened this issue Apr 11, 2020 · 0 comments · Fixed by #1046
Assignees
Labels
[Priority] Blocker [Status] In Progress Tracking issues with work in progress
Milestone

Comments

@ocean90
Copy link
Member

ocean90 commented Apr 11, 2020

The current notes/comments implementation was pushed via #209. Unfortunately, the merged PR #975 isn't yet ready for a public release. Bugs already have been reported in #998, #999, or #1000. I also did another quick test:

  • I was able to submit an empty note.
  • After I submitted a note the next translation opened.
  • The note wasn't visible after a reload.
  • The layout is broken

design-1

Bildschirmfoto 2020-04-11 um 15 07 37

The other remaining issue is that there are no (global) tools to support moderating the discussions.

That's why I'm proposing to remove the current implementation. This should give us the chance for another try with a clean state in a later version.
This was also discussed in person at WCEU with the same conclusion.

@ocean90 ocean90 added this to the 3.0 milestone Apr 11, 2020
@ocean90 ocean90 self-assigned this Apr 11, 2020
@ocean90 ocean90 added the [Status] In Progress Tracking issues with work in progress label Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Priority] Blocker [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant