Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thing: Normalize int fields to be integers #1050

Closed
ocean90 opened this issue Apr 12, 2020 · 0 comments · Fixed by #1051
Closed

Thing: Normalize int fields to be integers #1050

ocean90 opened this issue Apr 12, 2020 · 0 comments · Fixed by #1051
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature is broken.
Milestone

Comments

@ocean90
Copy link
Member

ocean90 commented Apr 12, 2020

There's currently a unit test failure:

1) GP_Test_Thing_Translation_set::test_copy_translations_from_should_copy_into_empty_set
/tmp/wordpress/tests/phpunit/includes/abstract-testcase.php:644
/tmp/wordpress/src/wp-content/plugins/GlotPress-WP/tests/phpunit/testcases/tests_things/test_thing_translation_set.php:15

This is because $destination_set_translations[0]->translation_set_id has the value "2" (string) while $destination_set->id is 2 (integer).

@ocean90 ocean90 added the [Type] Bug An existing feature is broken. label Apr 12, 2020
@ocean90 ocean90 added this to the 3.0 milestone Apr 12, 2020
@ocean90 ocean90 self-assigned this Apr 12, 2020
@ocean90 ocean90 added the [Status] In Progress Tracking issues with work in progress label Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature is broken.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant