Wrong error message for translations with a missing set ID

[ocean90]

Noticed this while working on #311.

$data = array(
    'user_id'            => 1,
    'original_id'        => 1,
    'status'             => 'current',
);
$plurals = array(
    'translation_0' => 'Zero',
    'translation_1' => '',
    'translation_2' => '',
    'translation_3' => '',
    'translation_4' => '',
    'translation_5' => '',
);

$data = array_merge( $data, $plurals );

$translation = $this->factory->translation->create( $data );
$this->assertFalse( $translation->validate() );
var_dump( $translation->errors );

Result of the var_dump():

array(6) {
  [0]=>
  string(82) "The textarea <strong>Translation 1</strong> is invalid and should be positive int!"
  [1]=>
  string(86) "The textarea <strong>Translation 2</strong> is invalid and should not be empty string!"
  [2]=>
  string(86) "The textarea <strong>Translation 3</strong> is invalid and should not be empty string!"
  [3]=>
  string(86) "The textarea <strong>Translation 4</strong> is invalid and should not be empty string!"
  [4]=>
  string(86) "The textarea <strong>Translation 5</strong> is invalid and should not be empty string!"
  [5]=>
  string(86) "The textarea <strong>Translation 6</strong> is invalid and should not be empty string!"
}

The first error message is wrong.

[toolstack]

Won't it be the right message after #311?

[ocean90]

The textarea Translation 1 is invalid and should be positive int!

That should be something like "The translation_set_id is invalid and should be positive int!"

[toolstack]

Ah, I see it now 😄.

[toolstack]

Found the issue, https://github.com/GlotPress/GlotPress-WP/blob/develop/gp-includes/validation.php#L152 is:

if( strpos( $name_field, 'translation_' ) === 0 ) {

which matches translation_set_id as well as translation_0, etc.

Need to replace it with a better matching function like:

if( 1 === preg_match( '/translation_[0-9]/', $name_field ) ) {