388: Fix project path during upgrade #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add associated doc blocks and formatting updates.
| } | ||
|
|
||
| if ( $db_version < 950 ) { | ||
| $wpdb->query( "UPDATE {$wpdb->gp_projects} SET `path`=SUBSTR(`path`, 1, LENGTH(`path`) - 1) WHERE `path` LIKE '%/';" ); |
There was a problem hiding this comment.
This needs to be CHAR_LENGTH() and let's use SUBSTRING(). Some whitespace before/after the equal sign would be nice too.
| @@ -27,7 +27,7 @@ | |||
| */ | |||
|
|
|||
| define( 'GP_VERSION', '2.1.0-alpha' ); | |||
| define( 'GP_DB_VERSION', '940' ); | |||
| define( 'GP_DB_VERSION', '950' ); | |||
There was a problem hiding this comment.
940 was a SVN revision, should we change the version to a date?
There was a problem hiding this comment.
I wondered where the number came from.
Either just an incrementing number (I chose ten, but any increment would do) or date.
Date is kind of ugly and does limit us to once change a day 😉.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #388.