Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary character in gp_radio_buttons() #610

Closed
Zodiac1978 opened this issue Nov 15, 2016 · 1 comment
Closed

Unnecessary character in gp_radio_buttons() #610

Zodiac1978 opened this issue Nov 15, 2016 · 1 comment
Assignees
Milestone

Comments

@Zodiac1978
Copy link

@Zodiac1978 Zodiac1978 commented Nov 15, 2016

bildschirmfoto 2016-11-15 um 14 39 42

This line should be corrected to:
$res .= "\t<input type='radio' id='" . esc_attr( "{$name}[{$value}]" ) . "' name='" . esc_attr( $name ) . "' value='" . esc_attr( $value ) . "' $checked />&nbsp;";

PR with all these branches is to complicated for me for this little bug ... sorry ;)

@toolstack toolstack added this to the 2.3 milestone Nov 15, 2016
@toolstack toolstack self-assigned this Nov 15, 2016
@toolstack
Copy link
Contributor

@toolstack toolstack commented Nov 15, 2016

The extra spaces aren't required, just the removal of the spurious single quote after $checked.

For your reference, PR's should be created against the develop branch.

@ocean90 ocean90 closed this in #611 Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants