Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discarding Warning (for URL missing) causes duplicate entry until reload #699

Closed
garretthyder opened this issue Apr 13, 2017 · 1 comment
Labels
[Type] Bug An existing feature is broken. [Type] Design
Milestone

Comments

@garretthyder
Copy link

Hello,

If you get a warning for say URL missing in translated string (which happens if you localize a plugin URL) then you'll get a warning;
screen shot 2017-04-12 at 11 22 59 am

If you discard this warning then the translation becomes approved (green) but a duplicate is created which is open for editing;
screen shot 2017-04-12 at 11 33 24 am

This is minor, if you reload then the duplicate disappears, but if you were to approve the second string before reload could create some conflict (that's a presumption I didn't actually test that part).

Let me know if I can clarify or assist,
Cheers

@ocean90 ocean90 added [Type] Bug An existing feature is broken. [Type] Design labels May 9, 2017
@ocean90 ocean90 added this to the Future milestone May 9, 2017
@toolstack
Copy link
Contributor

Found the issue, it's actually not a duplicate entry, just that the "preview" row and the "editor" row are both being displayed at the same time.

I've created a PR to resolve and also updated the behaviour of the dismiss action so that it moves to the next translation (assuming all errors are clear) just like the "Add translation" button does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature is broken. [Type] Design
Projects
None yet
Development

No branches or pull requests

3 participants