Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make glossary entries case insensitive #703

Closed
garretthyder opened this issue Apr 26, 2017 · 6 comments
Closed

Make glossary entries case insensitive #703

garretthyder opened this issue Apr 26, 2017 · 6 comments
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@garretthyder
Copy link

Hello,

With Glotpress Glossary the words within the glossary are underlined on the original string making it easier to see what should be translated. That's especially helpful with the flavoured english translations (Canadian, a=Australian, etc). But currently they're all case sensitive so if you have color>colour in the glossary but it's a single word string for Color then it won't be underlined.

Would be nice if glossary terms are case-insensitive. Please let me know if this won't be picked up anytime soon as I'll manually add capitalized versions to the Glossary.

Thank you
Original meta.trac ticket - https://meta.trac.wordpress.org/ticket/2778

@webaware
Copy link

IME, this is not true. Terms are case-insensitive. Perhaps provide an example of a failure, because there could be another factor (e.g. not being detected as a whole word correctly, due to parentheses)

@garretthyder
Copy link
Author

Hi @webaware,
The original trac ticket has some examples - https://meta.trac.wordpress.org/ticket/2778
Do you have the GlotDict extension installed by chance, as netweb indicated in the trac ticket he had the same initial assumption but upon disabling the GlotDict extension was able to reproduce the issue.
*Also I've seen some Glossaries out there with both lower and capitalized versions, which if we make case insensitive won't be required any longer.
Thanks

@toolstack
Copy link
Contributor

I can confirm the glossary matching is case sensitive, it's an easy technical fix.

@toolstack toolstack self-assigned this Apr 27, 2017
@toolstack toolstack added [Type] Enhancement A suggestion for improvement. [Status] In Progress Tracking issues with work in progress labels Apr 27, 2017
@garretthyder
Copy link
Author

Thanks @toolstack

@webaware
Copy link

Ah yes, indeed I have GlotDict. My bad for not reading the trac ticket.

@garretthyder
Copy link
Author

All good @webaware, was my bad for not posting here originally

@ocean90 ocean90 changed the title Feature Request - GlotPress Glossary Highlighting - Please make case insensitive Make glossary entries case insensitive May 1, 2017
@ocean90 ocean90 added this to the 2.4 milestone May 9, 2017
@toolstack toolstack modified the milestones: 3.0, 2.4 Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants