Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glossary Term highlighting disappears after interacting with an entry #704

Closed
garretthyder opened this issue Apr 26, 2017 · 1 comment
Closed
Assignees
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature is broken.
Milestone

Comments

@garretthyder
Copy link

Hello,

Wanted to flag a minor issue with the Glossary term highlighting on strings. When initially viewing a string you'll note the glossary terms are underlined appropriately, however if you act on the item rejecting, etc. And then click details again to expand it the terms are no longer highlighted/underlined.

Below screen is after I rejected the translated string, as can be seen the glossary terms for catalog are no longer underlined;
http://i.imgur.com/gmUa5Ns.png

Reloading the page after submitting a translated string I can see it's re-underlined;
http://i.imgur.com/aLvTwnS.png

Since Reject seems to be done via ajax and the glossary is php, maybe on ajax updates we need a js script to re-glossary/underline terms.
*That's an assumption as I don't know nearly enough about how it works.

Let me know if you need any clarification,
Cheers
Original meta.trac ticket - https://meta.trac.wordpress.org/ticket/2785

@toolstack
Copy link
Contributor

I've confirmed this is a bug and have a fix, it's not js related, there's a missing PHP function call during the ajax load to mark glossary terms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature is broken.
Projects
None yet
Development

No branches or pull requests

2 participants