Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation to Glossary Terms creation for blocking duplicates #745

Closed
garretthyder opened this issue Jun 23, 2017 · 0 comments · Fixed by #947
Closed

Add validation to Glossary Terms creation for blocking duplicates #745

garretthyder opened this issue Jun 23, 2017 · 0 comments · Fixed by #947
Assignees
@toolstack
Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Milestone
3.0

Comments

@garretthyder
Copy link

Hello,

Currently there's no validation on Glossary Term creation for blocking duplicates, would like to have that to avoid duplicates. Probably just block their creation and provide a warning/error message.

Screen showing duplicates;
screen shot 2017-06-23 at 10 10 31 am

Thank you
@toolstack toolstack self-assigned this Jun 23, 2017
@toolstack toolstack added the [Type] Enhancement A suggestion for improvement. label Jun 23, 2017
@toolstack toolstack added this to the 2.4 milestone Jun 23, 2017
@toolstack toolstack mentioned this issue Jun 23, 2017
Merged
@toolstack toolstack added the [Status] In Progress Tracking issues with work in progress label Jun 23, 2017
@ocean90 ocean90 changed the title Enhancement - Add validation to Glossary Terms creation for blocking duplicates Add validation to Glossary Terms creation for blocking duplicates Jun 27, 2017
@toolstack toolstack mentioned this issue Jun 30, 2017
Merged
@toolstack toolstack modified the milestones: 3.0, 2.4 Aug 15, 2017
@garretthyder garretthyder mentioned this issue Oct 12, 2018
Closed
garretthyder pushed a commit to garretthyder/GlotPress-WP that referenced this issue Oct 12, 2018
Removed part_of_speech from the so as to avoid blocking multiple noun…
319154a 
… translations. Fixes GlotPress#946 and Reverts some of the unintentional code merged to resolve GlotPress#745
@garretthyder garretthyder mentioned this issue Oct 12, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@toolstack toolstack

Labels
[Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
3.0
Development

Successfully merging a pull request may close this issue.

Don't block multiple Glossary entries with same part_of_speech. garretthyder/GlotPress-WP
2 participants
@garretthyder @toolstack