Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed URL doesn't trigger warning #785

Closed
garretthyder opened this issue Jul 10, 2017 · 3 comments
Closed

Changed URL doesn't trigger warning #785

garretthyder opened this issue Jul 10, 2017 · 3 comments
Labels
[Status] Invalid Issue outside GlotPress/Not a valid issue

Comments

@garretthyder
Copy link

Hello,

When I went to translate a string containing '(https://wordpress.org/plugins/debug-bar/)' and localized it to '(https://en-ca.wordpress.org/plugins/debug-bar/)' I was expecting the URL change warning but didn't receive anything. Is the regex ignoring it because it's surrounded in parentheses?

Permalink - https://translate.wordpress.org/projects/wp-plugins/debug-bar-screen-info/dev-readme/en-ca/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=1720714&filters%5Btranslation_id%5D=50534103

Thanks

@toolstack toolstack added the [Status] Invalid Issue outside GlotPress/Not a valid issue label Jul 11, 2017
@toolstack
Copy link
Contributor

As mentioned before (see #783) , URL warnings are part of translate.w.org, not GlotPress

@SergeyBiryukov
Copy link
Member

I was expecting the URL change warning but didn't receive anything.

That's intentional, WordPress.org links are allowed to be changed to a subdomain.

@garretthyder
Copy link
Author

Thanks @toolstack I'll move this into translate.w.org

@SergeyBiryukov I appreciate the information, I tested a couple as I definitely recalled seeing the warning on a few occassions and found that when the URL is standalone or within parentheses () no warning is triggered. However if the URL is within a link element it does trigger a warning;
screen shot 2017-07-11 at 9 19 57 am
Permalink - https://translate.wordpress.org/projects/wp-plugins/debug-bar-constants/dev-readme/en-ca/default?filters%5Bstatus%5D=either&filters%5Boriginal_id%5D=1668546&filters%5Btranslation_id%5D=50545119

I've opened this on meta trac here;
https://meta.trac.wordpress.org/ticket/2949

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Invalid Issue outside GlotPress/Not a valid issue
Projects
None yet
Development

No branches or pull requests

3 participants