Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter wp_locale for zh_SG #823

Closed
tobifjellner opened this issue Sep 14, 2017 · 5 comments
Closed

Add parameter wp_locale for zh_SG #823

tobifjellner opened this issue Sep 14, 2017 · 5 comments
Assignees

Comments

@tobifjellner
Copy link
Contributor

tobifjellner commented Sep 14, 2017

Chinese (Singapore) zh_SG has been requested for activation on translate-wordpress-org.
Request URL: https://make.wordpress.org/polyglots/2017/07/13/chinese-singapore-gte-request/

Therefore, we need to add the parameter wp_locale for this locale.

Previous description:
When I tried to search for zh_SG at https://translate.wordpress.org/ I got no match.
The reason seems to be that the parameter wp_locale is undefined and therefore defaults to the slug value.

Currently, three locales are presented with hyphen (-) rather than underscore. They are:
el-po
zh-sg
fr-ch

@tobifjellner tobifjellner self-assigned this Sep 14, 2017
@tobifjellner
Copy link
Contributor Author

For the moment, we'll only update zh_SG.

@tobifjellner tobifjellner changed the title Parameter wp_locale missing for three locales Add parameter wp_locale for zh_SG Sep 14, 2017
@toolstack
Copy link
Contributor

Not all locales have wp_locale properties and I expect that will become more common in the future with CLDR support.

I believe the polyglot's team usually chooses the value for them when they are added.

@tobifjellner
Copy link
Contributor Author

In a comment on Slack, @ocean90 commented that this parameter is added when a locale gets activated on translate.wordpress.org.
We've got a request for zh_SG now, so that locale will be updated. (And several other domains are about to be added, too.)

@toolstack
Copy link
Contributor

That's one of the slightly weird interactions between GP and translate.w.org, as GP doesn't actually use the parameter.

@tobifjellner
Copy link
Contributor Author

Issue description has been updated:
Chinese (Singapore) zh_SG has been requested for activation on translate-wordpress-org.
Request URL: https://make.wordpress.org/polyglots/2017/07/13/chinese-singapore-gte-request/

Therefore, we need to add the parameter wp_locale for this locale.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants