Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warnings count and filter view for warnings differ #919

Closed
ocean90 opened this issue Jul 21, 2018 · 0 comments
Closed

Warnings count and filter view for warnings differ #919

ocean90 opened this issue Jul 21, 2018 · 0 comments
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature is broken.
Milestone
3.0

Comments

@ocean90
Copy link
Member

ocean90 commented Jul 21, 2018

This is due to a different query when counting the translations and when fetching them for display.

GP_Translation_Set::update_status_breakdown() uses warnings IS NOT NULL
https://github.com/GlotPress/GlotPress-WP/blob/2.3.1/gp-includes/things/translation-set.php#L464

GP_Translation::for_translation() uses warnings IS NOT NULL and warnings != ""
https://github.com/GlotPress/GlotPress-WP/blob/2.3.1/gp-includes/things/translation.php#L340-L342
The later was added in ee2b016 for https://glotpress.trac.wordpress.org/ticket/435.
@ocean90 ocean90 added the [Type] Bug An existing feature is broken. label Jul 21, 2018
@toolstack toolstack mentioned this issue Sep 27, 2018
Merged
@toolstack toolstack added the [Status] In Progress Tracking issues with work in progress label Sep 27, 2018
@toolstack toolstack added this to the 3.0 milestone Sep 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Status] In Progress Tracking issues with work in progress [Type] Bug An existing feature is broken.
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
2 participants
@ocean90 @toolstack