fix some typing mistakes #1023
Merged
fix some typing mistakes #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yoavf can you check this please |
pedro-mendonca
approved these changes
Jan 11, 2020
|
That's a strange failure on TravisCI, I've restarted the builds to see if it was just temporary, if not I'll take a look in to it some more. |
toolstack
reviewed
Apr 5, 2020
| @@ -697,11 +697,11 @@ | |||
| extractor = ts.getParserById( ts.getData( header, configHeaders, 'extractor' ) ); | |||
| parser = ts.getParserById( ts.getData( header, configHeaders, 'sorter' ) ); | |||
| noParser = ts.getData( header, configHeaders, 'parser' ) === 'false'; | |||
| // empty cells behaviour - keeping emptyToBottom for backwards compatibility | |||
| // empty cells behavior - keeping emptyToBottom for backwards compatibility | |||
There was a problem hiding this comment.
Not going to block it because of these, but behaviour is a correct spelling... in Canada ;)
There was a problem hiding this comment.
Third-party libraries shouldn't be changed at all and reported upstream instead.
There was a problem hiding this comment.
Agreed, it didn't even click that it was in a library. There is a new version of the library so I'll create an issue/PR to update it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix some typing mistakes