Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

582: Modal for keyboard shortcuts #856

Closed
wants to merge 5 commits into from
Closed

582: Modal for keyboard shortcuts #856

wants to merge 5 commits into from

Conversation

Mte90
Copy link
Contributor

@Mte90 Mte90 commented Nov 30, 2017 •
edited

As promised here there is the code but the UI is very ugly.
#582
screenshot_20171130_225304

@Mte90
Copy link
Contributor Author

Mte90 commented Dec 9, 2017

We need to define the UI if require other changes and remove them from js to css.
Also next to find a new content.

@ocean90
Copy link
Member

ocean90 commented Apr 12, 2020

Thanks for your work on this.

Though, I'm going to close this as I don't think that we should reinvent the wheel here. I'd consider using existing components like from Gutenberg or Bootstrap instead.

@ocean90 ocean90 closed this Apr 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mte90 @ocean90