Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add keda dashboard #11

Merged
merged 11 commits into from May 23, 2023
Merged

chore: add keda dashboard #11

merged 11 commits into from May 23, 2023

Conversation

debu99
Copy link
Contributor

@debu99 debu99 commented May 23, 2023

No description provided.

venkatamutyala
venkatamutyala requested changes May 23, 2023
View reviewed changes
templates/keda.yaml Outdated
},
"editorMode": "code",
"expr": "sum by(job) (rate(keda_scaler_errors_total{}[5m]))",
"legendFormat": "{{ job }}",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will need to be escaped. See the README.md beyond that looks fine. i assume the dashboard will work as-is? Can you do a quick test after the building for development? The chart will be published to: https://incubating-helm.gpkg.io/platform and you will likely need to enable dev mode so that the incubating repos are loaded/accessible: https://github.com/development-captains/test-1-np.saturn.onglueops.rocks/blob/main/platform.yaml#L2

ref: https://github.com/internal-GlueOps/team/wiki/Publishing-Helm-Charts-(development-incubating-and-production)

Copy link
Contributor Author

@debu99 debu99 May 23, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested, what version should i use in the PR?
image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per semver please use 0.8.0.

For the platform-helm-chart-platform please bump the minor as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, GlueOps/platform-helm-chart-platform#32

@debu99 debu99 temporarily deployed to development May 23, 2023 11:27 — with GitHub Actions Inactive
@debu99
Merge branch 'chore/add-keda-dashboard' of github.com:GlueOps/platfor…
979eb8c 
…m-helm-chart-grafana-dashboards into chore/add-keda-dashboard
@debu99 debu99 temporarily deployed to development May 23, 2023 12:05 — with GitHub Actions Inactive
@venkatamutyala
Copy link
Contributor

venkatamutyala commented May 23, 2023 •
edited

@debu99 Per semver please use 0.8.0.

For the platform-helm-chart-platform please bump the minor as well.

ref: https://github.com/GlueOps/platform-helm-chart-platform/blob/main/templates/application-glueops-grafana-dashboards.yaml#L27

@debu99 debu99 temporarily deployed to development May 23, 2023 16:30 — with GitHub Actions Inactive
@venkatamutyala venkatamutyala merged commit 60f354b into main May 23, 2023
@venkatamutyala venkatamutyala deleted the chore/add-keda-dashboard branch May 23, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venkatamutyala venkatamutyala venkatamutyala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@debu99 @venkatamutyala @glueops-terraform-svc-account