Skip to content
This repository has been archived by the owner on Jan 10, 2021. It is now read-only.

Implemented and tested a mini SRP6 library. #7

Merged
merged 3 commits into from
Jan 30, 2018
Merged

Implemented and tested a mini SRP6 library. #7

merged 3 commits into from
Jan 30, 2018

Conversation

Glusk
Copy link
Owner

@Glusk Glusk commented Jan 30, 2018

Check if okay.

@Glusk
Copy link
Owner Author

Glusk commented Jan 30, 2018

Tabs should be replaced with spaces.

@Glusk
Copy link
Owner Author

Glusk commented Jan 30, 2018

maven-checkstyle-plugin might produce a “Plugin execution not covered by lifecycle configuration..." error in Eclipse. Problems view -> Quick Fix solved it for me as suggested in this comment.

@Glusk
Copy link
Owner Author

Glusk commented Jan 30, 2018 •
edited
Loading

Initially checkstyle was added to the project with the intention of fixing white spaces. However it revealed several other issues (checkstyle.xml in 652e23a comments out or reconfigures those) which deserve a more in-depth and separate treatment.

Other than that the code seems correct and #6 can be closed.

@Glusk Glusk merged commit 52ba1c9 into master Jan 30, 2018
@Glusk Glusk deleted the srp6 branch January 30, 2018 16:23
@Glusk Glusk mentioned this pull request Feb 8, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Glusk