Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Consolidate flowchart arrow length #110

Merged
merged 2 commits into from
Jul 17, 2022
Merged

🎨 Consolidate flowchart arrow length #110

merged 2 commits into from
Jul 17, 2022

Conversation

Glutexo
Copy link
Owner

@Glutexo Glutexo commented Jul 15, 2022

All Mermaid arrows now have two dashes.

All Mermaid arrows now have two dashes.
@Glutexo Glutexo requested a review from nappex July 15, 2022 17:14
@Glutexo Glutexo self-assigned this Jul 15, 2022
@Glutexo Glutexo added the documentation Improvements or additions to documentation label Jul 15, 2022
@nappex
Copy link
Collaborator

nappex commented Jul 16, 2022

it was intention. if you writw more dash, the line is longer and flowchart looked better because certain cell move to more suitable place

@Glutexo
Copy link
Owner Author

Glutexo commented Jul 16, 2022

You are right! 😮 Your version looks much nicer!

 flowchart LR
     START             -->           operator(OPERATOR)
     operator    -- <hash>.urls --->    downloader(DOWNLOADER)
     downloader  -- <hash>.raw --->      parser(PARSER)
     parser      -- <hash>.json -->       operator
     operator           -->          MATERIALIZATION
Loading
 flowchart LR
     START             -->           operator(OPERATOR)
     operator    -- <hash>.urls -->    downloader(DOWNLOADER)
     downloader  -- <hash>.raw -->      parser(PARSER)
     parser      -- <hash>.json -->       operator
     operator           -->          MATERIALIZATION
Loading

@Glutexo
Copy link
Owner Author

Glutexo commented Jul 16, 2022

If I use the triple-dash version for the “parser → operator” line, the graph looks the same, yet the arrows are more consistent:

  • Triple-dash for the primary cycle,
  • double-dash for the input and output.

Look:

 flowchart LR
     START             -->           operator(OPERATOR)
     operator    -- <hash>.urls --->    downloader(DOWNLOADER)
     downloader  -- <hash>.raw --->      parser(PARSER)
     parser      -- <hash>.json --->       operator
     operator           -->          MATERIALIZATION
Loading

The triple-dash arrows make the lines longer. Like that, the graph looks much nicer: the primary cycle is clearly separated from the input and output.
@Glutexo
Copy link
Owner Author

Glutexo commented Jul 16, 2022

I updated the Pull Request with the consistent triple-dash version. Please take a fresh look and tell me what you think.

@Glutexo Glutexo merged commit e51daa1 into master Jul 17, 2022
@Glutexo Glutexo deleted the flowchart-arrows branch July 17, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants