🚚 Append .raw to the downloaded file name #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files with an extension are more easily filterable by wildcards than files with none. It is also more consistent with having an extension for each file type.
|
This is ready for review, @nappex. |
nappex
previously approved these changes
May 16, 2023
his commit changes the variable name from 'downloader_suffix' to 'suffix' in the relevant test code. This helps avoid the implication that we are using more than one suffix in this test, which could lead to confusion. It also aligns the naming convention in this test with that in the production code, where 'suffix' is used in the same context.
nappex
approved these changes
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #146 (comment), the files with an extension are more easily filterable by wildcards than files with none. It is also more consistent with having an extension for each file type.