Parametrize output filename #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows to use `tmp_dir` for `download/2` (now `/3`) tests.
This was referenced Jan 22, 2022
Closed
nappex
approved these changes
Jan 28, 2022
Glutexo
commented
Jan 29, 2022
| end | ||
|
|
||
| def download(url, http) do | ||
| def download(url, http, path) do |
There was a problem hiding this comment.
Just thinking, wouldn’t it be more intuitive to have the literal input data collected on one side and the behaviors on the other side? Considering we already moved url to the beginning, I’d bring path there too.
Suggested change
| def download(url, http, path) do | |
| def download(url, path, http) do |
| @@ -10,16 +10,16 @@ defmodule Onigumo do | |||
| http = http_client() | |||
|
|
|||
| load_urls(@input_path) | |||
| |> Enum.map(&download(&1, http)) | |||
| |> Enum.map(&download(&1, http, @output_path)) | |||
There was a problem hiding this comment.
Suggested change
| |> Enum.map(&download(&1, http, @output_path)) | |
| |> Enum.map(&download(&1, @output_path, http)) |
| @@ -20,7 +21,7 @@ defmodule OnigumoTest do | |||
| end | |||
| ) | |||
|
|
|||
| assert(:ok == Onigumo.download(@url, HTTPoisonMock)) | |||
| assert(:ok == Onigumo.download(@url, HTTPoisonMock, @output_path)) | |||
There was a problem hiding this comment.
Suggested change
| assert(:ok == Onigumo.download(@url, HTTPoisonMock, @output_path)) | |
| assert(:ok == Onigumo.download(@url, @output_path, HTTPoisonMock)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to use
tmp_dirfordownload/2(now/3) tests.Fixes #32 if not considering #29.