-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move input filename to config #45
Conversation
An input filename is a configuration value, it does not have to be a module constant. This extraction allows to use this value in tests too.
Merged current elixir into this. Resolved conflicts. I introduced a new change from the previous version. Instead of using a hardcoded |
Merged current elixir into this. Resolved conflicts, extended the usage of the config variable to the new tests. |
Merged current elixir into this. Resolved conflicts, extended the usage of the config variable to the new tests again. Nice new piping has emerged. Application.get_env(:onigumo, :input_path)
|> load_urls()
|> download(http, path) |
An input filename is a configuration value, it does not have to be a module constant. This extraction allows to use this value in tests too.
With this change, I removed the
@testfile_with_urls
attribute from the tests. Its purpose was to expose an otherwise inaccessible value in theOnigumo
module. With@input_file
moved to the config, this is no longer necessary, as it’s accessible withApplication.get_env(:onigumo, :input_file)
.load_urls/1
takes the filename as an argument and did not have to use the global value even before this change.Fixes #31.