Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌐 Translate About and Architecture #91

Closed
wants to merge 1 commit into from

Conversation

Glutexo
Copy link
Owner

@Glutexo Glutexo commented Jul 5, 2022

No description provided.

@Glutexo Glutexo requested a review from nappex July 5, 2022 20:51
@Glutexo Glutexo self-assigned this Jul 5, 2022
@Glutexo Glutexo changed the title Transtlate About and Architecture Translate About and Architecture Jul 6, 2022
@nappex
Copy link
Collaborator

nappex commented Jul 7, 2022

Just think, does it make you sense to add info about which protocols we're supporting somewhere in README info? I think that support of other protocols instead just HTTP or HTTPS does not make sense but I am not sure....

@Glutexo Glutexo marked this pull request as draft July 9, 2022 19:34
@Glutexo
Copy link
Owner Author

Glutexo commented Jul 9, 2022

Just think, does it make you sense to add info about which protocols we're supporting somewhere in README info? I think that support of other protocols instead just HTTP or HTTPS does not make sense but I am not sure....

It may make sense in the Downloader section or the general overview. But it feels similar to the JSON dispute earlier: it is too implementation-specific. Also, although we didn’t think about supporting anything other than HTTP, it makes sense to scrape an FTP drive, a Git repository, an IMAP mailbox, or a WebDAV storage.

We don’t support anything other than HTTP for now, but even that is still very rudimentary. It would be bold even to say we support HTTP.

@Glutexo
Copy link
Owner Author

Glutexo commented Jul 9, 2022

I started to dislike the changes I proposed. The translation was not accurate and even incorrect. Also, the Pull Request is too big, amending two sections simultaneously. I’ll replace it with better ones.

Thank you for the review!

@Glutexo Glutexo added the documentation Improvements or additions to documentation label Jul 9, 2022
@Glutexo Glutexo changed the title Translate About and Architecture 🌐 Translate About and Architecture Jul 9, 2022
@nappex
Copy link
Collaborator

nappex commented Jul 10, 2022

Ok, unfortunately my english skills are not up to the level which I could assess quality of your translation. I've just known that it made sense and I understood the content from it.

This was referenced Jul 13, 2022
@Glutexo
Copy link
Owner Author

Glutexo commented Jul 13, 2022

Superseded by #104, #105, and #106.

@Glutexo
Copy link
Owner Author

Glutexo commented Jul 15, 2022

Replaced by #107.

@Glutexo Glutexo closed this Jul 15, 2022
@Glutexo Glutexo deleted the readme-about-architecture branch July 15, 2022 11:06
@Glutexo Glutexo linked an issue Aug 1, 2022 that may be closed by this pull request
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🌐 Translate README
2 participants