Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check LDAP passwords and reject invalid shell characters like $ #299

Closed
tpsands opened this issue May 20, 2017 · 3 comments
Closed

Check LDAP passwords and reject invalid shell characters like $ #299

tpsands opened this issue May 20, 2017 · 3 comments
Assignees
Labels
enhancement Update to existing feature or functionality
Milestone

Comments

@tpsands
Copy link

tpsands commented May 20, 2017

From support.gluu.org issue #4115. Password entered at setup caused issue.

After setup, oxAuth and oxTrust couldn't access LDAP. ldapsearch bind attempt failed. After troubleshooting, I thought the password may be too complex or too long. I tried a simpler password and that worked.

Initial password had 16 characters. The 10th character was a dollar sign ($) and all others were alphanumeric. The simplified password that allowed the system to connect to LDAP was 8 characters and all alphanumeric.

@mzico mzico added the enhancement Update to existing feature or functionality label May 20, 2017
@mzico mzico added this to the CE 3.1.0 milestone May 20, 2017
@mzico
Copy link
Contributor

mzico commented May 20, 2017

@zamilskhan : Can you please try to reproduce the issue? Please check which one is not accepting special character password: (a) setup script? (b) OpenLDAP (c) oxAuth.

@tpsands
Copy link
Author

tpsands commented May 24, 2017

I re-installed with a short superuser password: adm$n. Again, the same failure where oxAuth nor oxTrust could access LDAP. Running ldapsearch at the command line said 'invalid credentials'. The dollar-sign ($) seems to be the culprit. The initial failure had a 16 character password which included a dollar-sign ($). The only point I enter that password is in the prompt from the setup.py script for superuser: "Optional: enter password for oxTrust and LDAP superuser."

I then re-reinstalled using an at-sign (@) in the superuser password and that worked. I've previously installed successfully with only alpha-numeric characters.

@nynymike
Copy link
Contributor

$ has a special meaning in shell scripts. The way we are using the password to run a script is causing that error. We should add a warning that $ is not allowed, and perhaps compare against other invalid shell characters.

@nynymike nynymike changed the title Longer password with special character makes LDAP inaccessible in Ubuntu14.04/16.04 Check LDAP passwords and reject invalid shell characters like $ May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Update to existing feature or functionality
Projects
None yet
Development

No branches or pull requests

4 participants