Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(admin-ui): include jans kc link feature to webhook #1630 #1634

Merged
merged 3 commits into from
Mar 29, 2024
Merged

feat(admin-ui): include jans kc link feature to webhook #1630 #1634

merged 3 commits into from
Mar 29, 2024

Conversation

jv18creator
Copy link
Contributor

closes #1630

@jv18creator
feat(admin-ui): include jans kc link feature to webhook #1630
c1500ea 
Signed-off-by: Jeet Viramgama <jviramgama5@gmail.com>
@mo-auto mo-auto added comp-admin-ui Component affected by issue or PR comp-flex-linux-setup Component affected by issue or PR kind-feature Issue or PR is a new feature request labels Mar 20, 2024
@jv18creator jv18creator marked this pull request as ready for review March 22, 2024 15:05
@jv18creator
fix(admin-ui): update feature name
bf0f780 
Signed-off-by: Jeet Viramgama <jviramgama5@gmail.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 22, 2024

Quality Gate Passed Quality Gate passed for 'flex_linux_setup'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

duttarnab
duttarnab requested changes Mar 26, 2024
View reviewed changes
Copy link
Contributor

@duttarnab duttarnab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see inline comments.

flex-linux-setup/flex_linux_setup/templates/aui_webhook.ldif Show resolved Hide resolved
@duttarnab
Copy link
Contributor

jans_keycloak_link_write
The feature - type is hard coded here. I think it should be taken from API

@jv18creator
Copy link
Contributor Author

jans_keycloak_link_write The feature - type is hard coded here. I think it should be taken from API

yes so basically, its a mere parameter a prop feature to pass in the component which is used in all the feature forms eg, custom script, client etc...

I think we don't a particular endpoint to fetch only single feature id such as jans_keycloak_link_write if a user is on a particular form.

@jv18creator
chore(admin-ui): constant feature list created
0ebbe59 
Signed-off-by: Jeet Viramgama <jviramgama5@gmail.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 29, 2024

Quality Gate Passed Quality Gate passed for 'flex_admin_ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

duttarnab
duttarnab approved these changes Mar 29, 2024
View reviewed changes
admin-ui/plugins/jans-kc-link/components/Tabs/BasicConfiguration.js Outdated
@@ -488,7 +488,7 @@ const BasicConfiguration = () => {
</Col>
</FormGroup>

<SharedFooter disabled={disabled} toggle={toggle} formik={formik} modal={modal} submitForm={submitForm} feature='jans_kc_link_write' />
<SharedFooter disabled={disabled} toggle={toggle} formik={formik} modal={modal} submitForm={submitForm} feature='jans_keycloak_link_write' />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jans_keycloak_link_write
The feature - type is hard coded here. I think it should be taken from API

flex-linux-setup/flex_linux_setup/templates/aui_webhook.ldif Show resolved Hide resolved
@duttarnab duttarnab merged commit d5d702c into main Mar 29, 2024
3 checks passed
@duttarnab duttarnab deleted the admin-ui-test-1630 branch March 29, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duttarnab duttarnab duttarnab approved these changes

@syntrydy syntrydy Awaiting requested review from syntrydy syntrydy is a code owner

Assignees

@duttarnab duttarnab

Labels
comp-admin-ui Component affected by issue or PR comp-flex-linux-setup Component affected by issue or PR kind-feature Issue or PR is a new feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(admin-ui): include jans kc link feature to webhook
3 participants
@jv18creator @duttarnab @mo-auto