Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply js-standard code guidelines on eslint #109

Closed
christian-hawk opened this issue Aug 19, 2020 · 5 comments · Fixed by #114
Closed

Apply js-standard code guidelines on eslint #109

christian-hawk opened this issue Aug 19, 2020 · 5 comments · Fixed by #114
Assignees

Comments

@christian-hawk
Copy link
Contributor

Currently we are not using a standard.
Between the options, https://standardjs.com/ is the most advanced and no bureaucracy.

@christian-hawk
Copy link
Contributor Author

suggestion: use eslint to extend standardjs

@kdhttps
Copy link
Contributor

kdhttps commented Sep 10, 2020

suggestion: use eslint to extend standardjs

@christian-hawk sorry, not getting you exactly. there are two ways to integrate standardjs.

  1. directly with standard npm as describe in standard docs.
  2. using eslint npx eslint --init which is also install some eslint libs

so do you want me to use 2nd option?

@christian-hawk
Copy link
Contributor Author

@kdhttps I understand that for CI/CD purposes standard npm should work.
But maybe eslint is more globally known and integrated on IDE and Text Editors, this is why I thought using standard as a plugin. What do you think?

I'm ok w/ any option thou.

@kdhttps
Copy link
Contributor

kdhttps commented Sep 12, 2020

I think let's use standardjs. it is used by well know companies and only one lib for everything without any extra configuration. @christian-hawk what you think?

@christian-hawk
Copy link
Contributor Author

Agreed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants