New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication betwen passport and auth script should be protected by token #20

Open
yurem opened this Issue Apr 25, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@yurem
Contributor

yurem commented Apr 25, 2018

Current passport authentication script don't validate if it trigger passport authentication or not Before redirecting to passport it should generate token and send it to passport. Passport should send it back with response to allow validate it.

Also passport sends user profile in JSON format. We should use JWT signed token for this.

We also can use nonce and return back it in JWT to to mitigate replay attacks.

@yurem yurem added this to the 3.1.4 milestone Apr 25, 2018

@yurem yurem closed this May 2, 2018

@yurem yurem reopened this May 2, 2018

@jgomer2001 jgomer2001 assigned jgomer2001 and unassigned syntrydy Jun 20, 2018

@jgomer2001

This comment has been minimized.

Contributor

jgomer2001 commented Jun 20, 2018

Assigning this myself since I'll be working on #38

@jgomer2001

This comment has been minimized.

Contributor

jgomer2001 commented Aug 6, 2018

Still missing:

We also can use nonce and return back it in JWT to to mitigate replay attacks.
I'm moving this feature for 4.0.0

@jgomer2001 jgomer2001 modified the milestones: 3.1.4, 4.0 Aug 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment