Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(openid-client): pass provided scope in auth request #539

Merged
merged 2 commits into from
May 31, 2023

Conversation

kdhttps
Copy link
Contributor

@kdhttps kdhttps commented May 26, 2023

PR Contains: openid-client lib not really taking its client object scope so need to pass it from config

closes #538

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #539 (7c5e1a8) into master (9c9e274) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 7c5e1a8 differs from pull request most recent head a65c310. Consider uploading reports for the commit a65c310 to get more accurate results

@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
+ Coverage   78.79%   78.87%   +0.08%     
==========================================
  Files          35       35              
  Lines         778      781       +3     
==========================================
+ Hits          613      616       +3     
  Misses        165      165              
Impacted Files Coverage Δ
config/test.js 100.00% <ø> (ø)
server/routes.js 64.28% <100.00%> (+1.32%) ⬆️

Copy link
Contributor

@christian-hawk christian-hawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a test to ensure this fix. Thanks mate.

@sonarcloud
Copy link

sonarcloud bot commented May 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@christian-hawk christian-hawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@christian-hawk christian-hawk merged commit 68342bd into master May 31, 2023
9 of 11 checks passed
@christian-hawk christian-hawk deleted the fix-538-openid-client branch May 31, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: extra scope are not sending in passport
2 participants