Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use multi-line keys and certs #156

Merged
merged 10 commits into from
Sep 22, 2022
Merged

fix: use multi-line keys and certs #156

merged 10 commits into from
Sep 22, 2022

Conversation

christian-hawk
Copy link
Contributor

@christian-hawk christian-hawk commented Sep 22, 2022

Ref issues: #154

  • Integration tests
  • Unit tests
  • Follow Clean Architecture dependency rules and flow of control

@codecov
Copy link

codecov bot commented Sep 22, 2022

Codecov Report

Merging #156 (85c3f75) into master (641cb4c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #156   +/-   ##
=======================================
  Coverage   99.44%   99.44%           
=======================================
  Files         144      144           
  Lines        1078     1078           
  Branches       66       66           
=======================================
  Hits         1072     1072           
  Misses          4        4           
  Partials        2        2           
Impacted Files Coverage Δ
...xy/src/use-cases/protocols/BaseKeyCertFormatter.ts 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@christian-hawk christian-hawk self-assigned this Sep 22, 2022
@christian-hawk christian-hawk linked an issue Sep 22, 2022 that may be closed by this pull request
@christian-hawk christian-hawk merged commit e9679ee into master Sep 22, 2022
@christian-hawk christian-hawk deleted the xmlenc_multiline branch September 22, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passport-saml breaks callback
1 participant