Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't insert ou=pairwiseIdentifiers tree node into DB which not supports tree model #1233

Closed
yurem opened this issue Jan 22, 2020 · 1 comment
Closed

Don't insert ou=pairwiseIdentifiers tree node into DB which not supports tree model #1233

yurem opened this issue Jan 22, 2020 · 1 comment
Assignees
@yuriyz
Labels
enhancement libs update, re-factroring, etc.
Milestone
4.1

Comments

@yurem
Copy link
Contributor

yurem commented Jan 22, 2020

We don't need to create tree node in couchbase DB like ou=pairwiseIdentifiers,inum=e2ff78ac-a5d8-40ff-ae1c-c05460919a06,ou=people,o=gluu. Here is example:
image

In persistenceEntryManager there is method hasBranchesSupport(primaryKey) which we should use to add or not this tree node.
@yurem yurem added the enhancement libs update, re-factroring, etc. label Jan 22, 2020
@yurem yurem added this to the 4.1 milestone Jan 22, 2020
yuriyz added a commit that referenced this issue Jan 22, 2020
@yuriyz
(4.1) Don't insert ou=pairwiseIdentifiers tree node into persistence …
783c70f 
…which not supports tree model #1233
yuriyz added a commit that referenced this issue Jan 22, 2020
@yuriyz
Don't insert ou=pairwiseIdentifiers tree node into persistence which …
0c0a179 
…not supports tree model #1233
@yuriyz
Copy link
Contributor

yuriyz commented Jan 22, 2020

Done in 4.1 and merged to master.

@yuriyz yuriyz closed this as completed Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

Labels
enhancement libs update, re-factroring, etc.
Projects
None yet
Milestone
4.1
Development

No branches or pull requests
2 participants
@yuriyz @yurem