Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FAPI : during test we noticed that c_hash and s_hash is not always present in id_token #1239

Closed
yuriyz opened this issue Jan 29, 2020 · 1 comment
Closed

FAPI : during test we noticed that c_hash and s_hash is not always present in id_token #1239

yuriyz opened this issue Jan 29, 2020 · 1 comment
Assignees
@yuriyz
Labels
enhancement libs update, re-factroring, etc.
Milestone
4.2

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Jan 29, 2020

image
@yuriyz yuriyz added the enhancement libs update, re-factroring, etc. label Jan 29, 2020
@yuriyz yuriyz added this to the 4.2 milestone Jan 29, 2020
@yuriyz yuriyz self-assigned this Jan 29, 2020
@yuriyz yuriyz changed the title FAPI : during test we noticed that c_hash and s_hash is not already present in id_token FAPI : during test we noticed that c_hash and s_hash is not always present in id_token Jan 29, 2020
yuriyz added a commit that referenced this issue Jan 29, 2020
@yuriyz
passed authorization code to id_token creation method at Token Endpoi…
25f5a68 
…nt which makes it include `c_hash` at id_token

#1239
@yuriyz
Copy link
Contributor Author

yuriyz commented Jan 29, 2020

re: c_hash, at Token Endpoint passed authorization code so it will be present for Authorization Code Flow.
re: s_hash, state is not in use by FAPI suite therefore it is missed.

@yuriyz yuriyz closed this as completed Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

Labels
enhancement libs update, re-factroring, etc.
Projects
None yet
Milestone
4.2
Development

No branches or pull requests
1 participant
@yuriyz