Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logout : conformance tests expect successful page if session was ended but post_logout_redirect_uri not provided #1286

Closed
yuriyz opened this issue Mar 6, 2020 · 1 comment
Closed

Logout : conformance tests expect successful page if session was ended but post_logout_redirect_uri not provided #1286

yuriyz opened this issue Mar 6, 2020 · 1 comment
Assignees
@yuriyz
Labels
enhancement libs update, re-factroring, etc.
Milestone
4.2

Comments

@yuriyz
Copy link
Contributor

yuriyz commented Mar 6, 2020

Describe the issue

Logout : conformance tests expect successful page if session was ended but post_logout_redirect_uri not provided

Currently we return error with message that logout is successful but we failed to validate post_logout_redirect_uri
@yuriyz yuriyz added the enhancement libs update, re-factroring, etc. label Mar 6, 2020
@yuriyz yuriyz added this to the 4.2 milestone Mar 6, 2020
@yuriyz yuriyz self-assigned this Mar 6, 2020
yuriyz added a commit that referenced this issue Mar 10, 2020
@yuriyz
logout : do not return error if post_logout_redirect_uri is not passe…
ae9d392 
…d since it's optional #1286
yuriyz added a commit that referenced this issue Mar 10, 2020
@yuriyz
Changed logout default message #1286
f4826ce
yuriyz added a commit that referenced this issue Mar 10, 2020
@yuriyz
corrected case when post_logout_redirect_uri is not present and front…
3ce16c7 
…channel_logout_uri is not set #1286
@yuriyz
Copy link
Contributor Author

yuriyz commented Mar 10, 2020

Done in 4.2. If post_logout_redirect_uri is not specified then we return frontchannel HTML which can be customized via End Session Script.

@yuriyz yuriyz closed this as completed Mar 10, 2020
yuriyz added a commit that referenced this issue Mar 13, 2020
@yuriyz
added sid claim to id_token #1286
f8d5f01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuriyz yuriyz

Labels
enhancement libs update, re-factroring, etc.
Projects
None yet
Milestone
4.2
Development

No branches or pull requests
1 participant
@yuriyz