New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The button to remove Source Ldap Server under LDAP Manage Authentication don't shows up on every screen. #1048

Closed
syntrydy opened this Issue Jul 25, 2018 · 6 comments

Comments

Projects
None yet
3 participants
@syntrydy
Contributor

syntrydy commented Jul 25, 2018

Description

The button to remove Source Ldap Server under LDAP Manage Authentication don't shows up every screen.

On large screen the button is visible but not on small screen(Lenovo X1 Carbon for example).

Even when the button is visible, it is not at the best position on the screen.
image

I guess a button like the one on the below screenshot should be good:
image

@syntrydy syntrydy added this to the 3.1.4 milestone Jul 25, 2018

@syntrydy syntrydy self-assigned this Jul 25, 2018

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Jul 25, 2018

The end result looks like this
image

@syntrydy syntrydy changed the title from The button to remove Source Ldap Server under LDAP Manage Authentication don't shows up every screen. to The button to remove Source Ldap Server under LDAP Manage Authentication don't shows up on every screen. Jul 25, 2018

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Jul 25, 2018

Sorry, the first commit is not present here because i forgot to add the issue number in commit message.

yurem added a commit that referenced this issue Jul 27, 2018

Merge pull request #1049 from /issues/1048
Ox trust/issues/1048
@earezki

This comment has been minimized.

Contributor

earezki commented Jul 29, 2018

This PR seem to be only merged in 3.1.4.
Would you please check and merge in Master as well ?
Thanks

@syntrydy

This comment has been minimized.

Contributor

syntrydy commented Jul 29, 2018

The 3.1.4 will be merged in master just before the release.

@syntrydy syntrydy closed this Aug 1, 2018

@natt-tester

This comment has been minimized.

natt-tester commented Aug 7, 2018

I've tested the behavior of the button and it's a bit off. Please fix it:
2018-08-07_20h10_35

@natt-tester

This comment has been minimized.

natt-tester commented Sep 6, 2018

@syntrydy, the buttons still show the same behavior -- tested in Ubuntu16, RC2. Maybe the change hasn't been merged?

bad button
bad_button2

@natt-tester natt-tester reopened this Sep 6, 2018

syntrydy pushed a commit that referenced this issue Sep 6, 2018

syntrydy added a commit that referenced this issue Sep 6, 2018

Merge pull request #1184 from /issues/1048
Fix source server remove button #1048

syntrydy pushed a commit that referenced this issue Sep 6, 2018

@syntrydy syntrydy closed this Sep 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment