Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The button to remove Source Ldap Server under LDAP Manage Authentication don't shows up on every screen. #1048

Closed
syntrydy opened this issue Jul 25, 2018 · 6 comments
Closed

The button to remove Source Ldap Server under LDAP Manage Authentication don't shows up on every screen. #1048

syntrydy opened this issue Jul 25, 2018 · 6 comments
Assignees
@syntrydy
Labels
enhancement libs update, re-factroring, etc.
Milestone
3.1.4

Comments

@syntrydy
Copy link
Collaborator

Description

The button to remove Source Ldap Server under LDAP Manage Authentication don't shows up every screen.

On large screen the button is visible but not on small screen(Lenovo X1 Carbon for example).

Even when the button is visible, it is not at the best position on the screen.
image

I guess a button like the one on the below screenshot should be good:
image
@syntrydy syntrydy added the enhancement libs update, re-factroring, etc. label Jul 25, 2018
@syntrydy syntrydy added this to the 3.1.4 milestone Jul 25, 2018
@syntrydy syntrydy self-assigned this Jul 25, 2018
@syntrydy
Copy link
Collaborator Author

The end result looks like this
image

@syntrydy syntrydy changed the title The button to remove Source Ldap Server under LDAP Manage Authentication don't shows up every screen. The button to remove Source Ldap Server under LDAP Manage Authentication don't shows up on every screen. Jul 25, 2018
syntrydy added a commit that referenced this issue Jul 25, 2018
@syntrydy
Improve/Fix ldap source server remove button #1048
234bb8a
@syntrydy
Copy link
Collaborator Author

Sorry, the first commit is not present here because i forgot to add the issue number in commit message.

yurem added a commit that referenced this issue Jul 27, 2018
@yurem
Merge pull request #1049 from /issues/1048
83ce8d6 
Ox trust/issues/1048
@earezki
Copy link
Contributor

earezki commented Jul 29, 2018

This PR seem to be only merged in 3.1.4.
Would you please check and merge in Master as well ?
Thanks

@syntrydy
Copy link
Collaborator Author

The 3.1.4 will be merged in master just before the release.

@syntrydy syntrydy closed this as completed Aug 1, 2018
@natt-tester
Copy link

I've tested the behavior of the button and it's a bit off. Please fix it:
2018-08-07_20h10_35

@natt-tester natt-tester reopened this Aug 7, 2018
yurem pushed a commit that referenced this issue Aug 9, 2018
@syntrydy @yurem
Improve/Fix ldap source server remove button #1048
2da2177
@natt-tester
Copy link

@syntrydy, the buttons still show the same behavior -- tested in Ubuntu16, RC2. Maybe the change hasn't been merged?

bad button
bad_button2

@natt-tester natt-tester reopened this Sep 6, 2018
syntrydy added a commit that referenced this issue Sep 6, 2018
@syntrydy
Fix source server remove button #1048
b27fd60
syntrydy added a commit that referenced this issue Sep 6, 2018
@syntrydy
Merge pull request #1184 from /issues/1048
f5989eb 
Fix source server remove button #1048
syntrydy added a commit that referenced this issue Sep 6, 2018
@syntrydy
Fix source server remove button #1048
68ebd87
@syntrydy syntrydy closed this as completed Sep 6, 2018
@syntrydy syntrydy mentioned this issue Sep 6, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@syntrydy syntrydy

Labels
enhancement libs update, re-factroring, etc.
Projects
None yet
Milestone
3.1.4
Development

No branches or pull requests
3 participants
@syntrydy @earezki @natt-tester