Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TR download metadata file in background #349

Closed
shekhar16 opened this issue Sep 14, 2016 · 5 comments
Closed

TR download metadata file in background #349

shekhar16 opened this issue Sep 14, 2016 · 5 comments
Assignees
Milestone

Comments

@shekhar16
Copy link
Collaborator

On TR save server is trying to download this metadata file fully. A result user is waiting at leas one minute. Download and validate metadata in background (i.e in new thread.).and We should also check if remote resource exists and cancel download it.

@yurem
Copy link
Contributor

yurem commented Sep 14, 2016

We need to close connection after checking if resource exists.

Also how are you going to sync metadata loading and metadata validation timers? If metadata is very big system can start validation earlier than it will be downloaded.

@shekhar16
Copy link
Collaborator Author

When it is completely downloaded , than only we are adding it in validation queue.So it is in sync for both metadata downloading and validation timer.

@shekhar16 shekhar16 removed their assignment Oct 3, 2016
@yurem
Copy link
Contributor

yurem commented Oct 4, 2016

I added comments to commit: 68398a4

Also I don't like method:

    @Asynchronous
    public void newThreadSaveSpMetaDataFileSourceTypeURI(UpdateTrustRelationshipAction updateTrustRelationshipAction){
    ...
        updateTrustRelationshipAction.

We should not pass instance of action to service. If we need instance we need to call Seam methods to do that.

Why we can't just set status of TR to "Download metadata" and update validation timer to use this as flag to trigger it download?

@willow9886 willow9886 added this to the CE 3.0.0 milestone Jan 25, 2017
@nynymike nynymike assigned otataryn and unassigned yurem Jan 30, 2017
@willow9886 willow9886 assigned yurem and unassigned otataryn Feb 13, 2017
@yurem yurem modified the milestones: CE 3.0.0, CE 3.0.1 Feb 27, 2017
@yurem yurem modified the milestones: CE 3.0.1, CE 3.0.2 Mar 6, 2017
@nynymike
Copy link
Contributor

nynymike commented Apr 8, 2017

Should this issue be closed?

@shekhar16
Copy link
Collaborator Author

@nynymike yes we cann close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants