#360 - Create stress/load test which should cover all APIs with mocked OP #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuriyz
requested changes
Aug 12, 2019
| @@ -36,10 +37,10 @@ public Processor(ValidationService validationService) { | |||
| this.validationService = validationService; | |||
| } | |||
|
|
|||
| public IOpResponse process(Command command) { | |||
| public IOpResponse process(Command command, OpClientFactory opClientFactory) { | |||
There was a problem hiding this comment.
remove it, it should be taken from guice injector.
| @@ -21,7 +23,12 @@ | |||
|
|
|||
| private static final Logger LOG = LoggerFactory.getLogger(RestResource.class); | |||
|
|
|||
| public RestResource() { | |||
|
|
|||
| private static OpClientFactory opClientFactory; | |||
| @@ -34,5 +38,6 @@ protected void configure() { | |||
| bind(DiscoveryService.class).in(Singleton.class); | |||
| bind(ValidationService.class).in(Singleton.class); | |||
| bind(StateService.class).in(Singleton.class); | |||
| bind(OpClientFactory.class).to(OpClientFactoryImpl.class).in(Singleton.class); | |||
There was a problem hiding this comment.
This is correct, now we need same but in TestGuiceModule which bind to mock factory.
bind(OpClientFactory.class).to(MockOpClientFactory.class).in(Singleton.class);
| super(command, injector, GetClientTokenParams.class); | ||
| this.opClientFactory = opClientFactory; |
There was a problem hiding this comment.
All these references are redundant, add to BaseOperation, it's responsibility of guice to construct it.
public OpClientFactory getOpClientFactory () {
return getInstance(OpClientFactory .class);
}
| } | ||
|
|
||
| @Override | ||
| public IOpResponse execute(GetClientTokenParams params) { | ||
| try { | ||
| final AuthenticationMethod authenticationMethod = AuthenticationMethod.fromString(params.getAuthenticationMethod()); | ||
| final String tokenEndpoint = getDiscoveryService().getConnectDiscoveryResponse(params.getOpHost(), params.getOpDiscoveryPath()).getTokenEndpoint(); | ||
| final TokenClient tokenClient = new TokenClient(tokenEndpoint); | ||
| //final TokenClient tokenClient = new TokenClient(tokenEndpoint); |
| * @author Yuriy Zabrovarnyy | ||
| * @version 0.9, 21/08/2013 | ||
| */ | ||
|
|
There was a problem hiding this comment.
Run it with Test Guice Module
@Guice(modules = org.gluu.oxd.mock.MockAppModule.class)
| } | ||
| } | ||
|
|
||
| private static void setOpClientFactory() { |
| @Parameters({"host", "opHost", "redirectUrls"}) | ||
| @BeforeSuite | ||
| public static void beforeSuite(String host, String opHost, String redirectUrls) { | ||
| try { |
There was a problem hiding this comment.
All this is copy/paste from org.gluu.oxd.server.SetUpTest#beforeSuite. Lets refactor existing code and avoid it.
|
Raised another PR #365 addressing this ticket. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#360 - Create stress/load test which should cover all APIs with mocked OP
#360
We have written mocks for
RegisterClientandTokenClient. and running test cases forRegisterSiteOperationandGetClientTokenOperationCould you please verify if we are going in right direction. If yes then we can implement same for all the clients.