Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix on join methods #20

Closed
wants to merge 6 commits into from
Closed

Bugfix on join methods #20

wants to merge 6 commits into from

Conversation

Gmousse
Copy link
Owner

@Gmousse Gmousse commented Apr 6, 2017

Linked to #19

@Gmousse Gmousse self-assigned this Apr 6, 2017
@Gmousse Gmousse mentioned this pull request Apr 6, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage increased (+0.09%) to 94.932% when pulling 3f8780f on hotfix/1.2.2 into 1bafb8a on develop.

1 similar comment
@coveralls
Copy link

coveralls commented Apr 6, 2017 •
edited

Coverage Status

Coverage increased (+0.09%) to 94.932% when pulling 3f8780f on hotfix/1.2.2 into 1bafb8a on develop.

PaulMest
PaulMest approved these changes Apr 6, 2017
View reviewed changes
Copy link

@PaulMest PaulMest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested it locally, but in desk-checking your tests it looks good. 👍

I've added one small comment to improve the accuracy/readability of your CHANGELOG.md comment.

CHANGELOG.md Outdated

**Changes**:
- Bugfix on join methods. They have now a correct behaviour. Thanks to @PaulMest
- .joinOuter had a wrong behaviour, making the difference between dataframes. .outerJoin is now an alias for .fullJoin. The old behaviour can now be find into .diff.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.outerJoin had a wrong behaviour. It would show the difference between dataframes. .outerJoin is now an alias for .fullJoin. The old behaviour can now be found in .diff.

@coveralls
Copy link

coveralls commented Apr 6, 2017 •
edited

Coverage Status

Coverage increased (+0.09%) to 94.932% when pulling 4941a93 on hotfix/1.2.2 into 1bafb8a on develop.

@coveralls
Copy link

coveralls commented Apr 6, 2017 •
edited

Coverage Status

Coverage increased (+0.09%) to 94.932% when pulling 4941a93 on hotfix/1.2.2 into 1bafb8a on develop.

@Gmousse Gmousse closed this Apr 6, 2017
@Gmousse Gmousse deleted the hotfix/1.2.2 branch August 15, 2017 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulMest PaulMest PaulMest approved these changes

Assignees

@Gmousse Gmousse

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Gmousse @coveralls @PaulMest