Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[compiler] toString(), hashCode() & Reloadable #284

Closed
Gmugra opened this issue Jan 21, 2022 · 1 comment
Closed

[compiler] toString(), hashCode() & Reloadable #284

Gmugra opened this issue Jan 21, 2022 · 1 comment
Labels
code refactoring enhancement New feature or request
Milestone
Release 0.80

Comments

@Gmugra
Copy link
Owner

Gmugra commented Jan 21, 2022

If Config-interface is not Reloadable - object is immutable.
And, in this case, it have no sense to calculate hashCode and build toString every time: they can be pre-calculated/pre-generated in the local varibales.

If Config-interface is Reloadable - object is mutable, but it is again have no sense to calculate hashCode and build toString every time. They can be be pre-calculated/pre-generated only in the reload() method.
Gmugra added a commit that referenced this issue Jan 23, 2022
@Gmugra
[compiler] toString(), hashCode() & Reloadable (#284)
fd653cb
Gmugra added a commit that referenced this issue Jan 23, 2022
@Gmugra
Merge pull request #289 from Gmugra/284_compiler_toString_and_more
1e70ae1 
[compiler] toString(), hashCode() & Reloadable (#284)
@Gmugra
Copy link
Owner Author

Gmugra commented Jan 24, 2022

Done.

@Gmugra Gmugra closed this as completed Jan 24, 2022
@Gmugra Gmugra added this to the Release 0.80 milestone Jan 25, 2022
@Gmugra Gmugra added the enhancement New feature or request label Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
code refactoring enhancement New feature or request
Projects
None yet
Milestone
Release 0.80
Development

No branches or pull requests
1 participant
@Gmugra