Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use demo for tests. Fix docs #94

Merged
merged 6 commits into from
Sep 25, 2023
Merged

Conversation

IanButterworth
Copy link
Collaborator

@IanButterworth IanButterworth commented Sep 23, 2023

This package doesn't work for me on MacOS Silicon due to #74 and I was surprised to see there weren't any tests.

This

  • Reuses the demo as an easy test to run
  • Fixes tests on linux x64 via xvfb
  • Updates to handle Documenter v1.0.0 which was being picked up with breakages due to a lack of compat entry for it.
  • Fixes broken links in the docs
  • Updates one part of an example that was outdated (rest of example not checked)

@Gnimuc
Copy link
Owner

Gnimuc commented Sep 23, 2023

looks like CI is not happy. better to exclude the test in CI.

@IanButterworth
Copy link
Collaborator Author

I could try getting it working with xvfb?

@IanButterworth IanButterworth force-pushed the ib/add_tests branch 2 times, most recently from 3ad457b to cbe07c3 Compare September 24, 2023 19:52
@IanButterworth
Copy link
Collaborator Author

IanButterworth commented Sep 24, 2023

@Gnimuc I've been trying to figure out what the broken link in the docs to IsDataType should be. It's not even in the commit where that doc was added 5847ae9

I see ImGuiPayload_IsDataType in lbcimgui. Perhaps there's a missing wrapper function for that?

@IanButterworth IanButterworth changed the title use demo for tests Use demo for tests. Fix docs Sep 24, 2023
@IanButterworth
Copy link
Collaborator Author

Should be good to review now @Gnimuc

Just see #94 (comment)

@IanButterworth IanButterworth mentioned this pull request Sep 25, 2023
@Gnimuc
Copy link
Owner

Gnimuc commented Sep 25, 2023

@Gnimuc I've been trying to figure out what the broken link in the docs to IsDataType should be. It's not even in the commit where that doc was added 5847ae9

I see ImGuiPayload_IsDataType in lbcimgui. Perhaps there's a missing wrapper function for that?

Yes. Some C++ methods are not wrapped.

@Gnimuc Gnimuc merged commit 23008e8 into Gnimuc:master Sep 25, 2023
16 checks passed
@IanButterworth IanButterworth deleted the ib/add_tests branch September 25, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants