Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Application id per build #102

Merged
merged 3 commits into from
Jun 1, 2024

Conversation

pnemonic78
Copy link
Collaborator

No description provided.

@Kaligula0
Copy link
Collaborator

Isn't it a (partial) duplicate of #84?

@Kaligula0
Copy link
Collaborator

Yeah, what I see is that #84 is 100% included in this #102.

djbrown
djbrown previously approved these changes May 17, 2024
Copy link

@djbrown djbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the commits on #84 were replaced (force pushed) with a single commit which happens to also be the first commit of this PR.

LGTM - but that might break CI (more than it already is)
you may merge and I'll fix firebase and pipeline setup afterwards.

@pnemonic78 @Kaligula0 did you read my #84 (comment)?
I feel kinda stuck in regards of an official playstore release.
should we just use the already existing pnemonic account?
I'm also thinking about sharing admin access to the github org and google cloud/firebase project to both of you.

@djbrown djbrown mentioned this pull request May 17, 2024
@pnemonic78
Copy link
Collaborator Author

pnemonic78 commented May 17, 2024

I prefer to keep ".pnemonic" personal. I only published it to app store because things too slow here.
It is better to have some sort of official "org.gnucash.pocket" application registered somehow...

@Kaligula0
Copy link
Collaborator

@pnemonic78 @Kaligula0 did you read my #84 (comment)? I feel kinda stuck in regards of an official playstore release. should we just use the already existing pnemonic account? I'm also thinking about sharing admin access to the github org and google cloud/firebase project to both of you.

Yeah, I saw that comment a few times, and I am sorry for late reply, but each time I didn't have the answer. I am also overwhelmed by the difficulty of registering organization developer account on Play Store. The payment of 25 bucks is not the biggest problem. Address, phone number, official registration… I have no idea how to do it in best way. Does anybody know of a similar case? Someone we can get in touch to ask how they managed to share such app?

As for the admin rights – I'm not sure I'm the right person. I try to be up to date with the repo, but I'm a hobby dev, and I can do only simple bug fixes in Android. I'm also not familiar with GH Actions and CI, that's why I am not able to fix it nor decide about it. Nevertheless, I try to keep up with the changes, issues and discussions.

djbrown
djbrown previously approved these changes May 30, 2024
djbrown
djbrown previously approved these changes May 30, 2024
@pnemonic78 pnemonic78 merged commit cfe1931 into GnuCash-Pocket:master Jun 1, 2024
5 checks passed
@pnemonic78 pnemonic78 deleted the application_id branch June 1, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants