Does the transaction have some problem? #97
Conversation
| if (splits.size() == 2) { | ||
| Split first = splits.get(0); | ||
| for (Split split : splits) { | ||
| if ((first != split) && first.isPairOf(split)) { |
There was a problem hiding this comment.
Isn't it better to do the same as in TransactionsListFragment.java? Just:
if (splits.size() == 2) {
if (splits.get(0).isPairOf(splits.get(1))) {
There was a problem hiding this comment.
How about that? Because I see each file has different logic here
|
Can you please add at least a brief description? What does this PR do? The change looks like just a rearrangement of code. |
|
Thanks for the screenshot. You mean that the 3rd tx ("ForEx") doesn't show it's target account? |
|
How to reproduce that? |
In the splits screen - make sure there is imbalance. |
|
I can't, it automatically adds 3rd account (imbalance account) and shows up just like your "AmEx" tx (with subtitle "3 splits"). |
|
|
|
Yeah, and then, when I click Save, then Save again, the tx gets saved with an additional Imbalance account, and the subtitle shows "3 splits". In which version does the bug show? I checked in your Google Play version. |
pnemonic78
force-pushed
the
issue/tx_blank_description
branch
from
0865ce5
to
04f244b
Compare
pnemonic78
force-pushed
the
issue/tx_blank_description
branch
from
04f244b
to
350b6f9
Compare
Looks very strange when the secondary label is blank.