Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proceeding with the documentation of price quote and gnucash-cli #316

Merged
merged 4 commits into from Jul 23, 2023

Conversation

CWehli
Copy link
Contributor

@CWehli CWehli commented Apr 11, 2023

No description provided.

Copy link
Member

@fellen fellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general an improvement.
Minor issues inline.

C/manual/ch_Finance-Quote.xml Outdated Show resolved Hide resolved
C/manual/ch_Finance-Quote.xml Outdated Show resolved Hide resolved
C/manual/ch_Finance-Quote.xml Outdated Show resolved Hide resolved
de/manual/ch_Finance-Quote.xml Outdated Show resolved Hide resolved
Copy link
Member

@fellen fellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 Kleinigkeiten sind mir in de noch aufgefallen. Wahrscheinlich exixstieren sie auch in C.

de/manual/ch_Finance-Quote.xml Outdated Show resolved Hide resolved
de/manual/ch_Finance-Quote.xml Outdated Show resolved Hide resolved
Copy link
Member

@fellen fellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This time I reviewed C and found few a points for discussion.

C/manual/ch_Finance-Quote.xml Outdated Show resolved Hide resolved
C/manual/ch_Finance-Quote.xml Outdated Show resolved Hide resolved
C/manual/ch_Finance-Quote.xml Outdated Show resolved Hide resolved
insert
- entities for MAC
- new lines
- variablelist
Change "finance-quote-*" to "fq-*" to get consistent html file names.
@code-gnucash-org code-gnucash-org merged commit c123def into Gnucash:stable Jul 23, 2023
3 checks passed
@fellen
Copy link
Member

fellen commented Jul 23, 2023

Danke!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants