Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L10n:de: manual: ch_Tools, section 'find transactions' #317

Merged
merged 1 commit into from Aug 7, 2023
Merged

L10n:de: manual: ch_Tools, section 'find transactions' #317

merged 1 commit into from Aug 7, 2023

Conversation

CWehli
Copy link
Contributor

@CWehli CWehli commented Apr 16, 2023

No description provided.

@CWehli CWehli force-pushed the de_Tools_Find_txn branch 3 times, most recently from d97ac80 to 79d01ed Compare April 19, 2023 19:51
fellen
fellen reviewed Apr 29, 2023
View reviewed changes
Copy link
Member

@fellen fellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions and ideas inline.

de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
@CWehli CWehli requested a review from fellen May 13, 2023 17:51
fellen
fellen reviewed Jul 21, 2023
View reviewed changes
Copy link
Member

@fellen fellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fell asleep last night. First catch.

de/manual/ch_Tools_Assistants.xml Show resolved Hide resolved
@CWehli CWehli requested a review from fellen July 30, 2023 18:00
fellen
fellen reviewed Jul 31, 2023
View reviewed changes
Copy link
Member

@fellen fellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sehr schön, gefällt mir.
Da sind aber noch ein Paar Diskussionspunkte inline.

de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
fellen
fellen reviewed Aug 3, 2023
View reviewed changes
Copy link
Member

@fellen fellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Da sind uns bei den vorigen Reviews doch noch ein paar Punkte entgangen.

de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
@CWehli CWehli requested a review from fellen August 5, 2023 15:06
fellen
fellen reviewed Aug 6, 2023
View reviewed changes
Copy link
Member

@fellen fellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Schau mal, ob dir dazu noch was einfällt.

de/manual/ch_Tools_Assistants.xml Outdated
Comment on lines 4 to 5
Version: 4.9
Last modified: Juli 2022
Last modified: Juli 2023
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dann kannst du die Version auch hochsetzen. ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich finde die Angabe der Versionsnummer hier irgendwie unglücklich, da die anderen Kapitel in dieser Datei nicht aktualisiert wurden und ggf. nur für eine bestimmte ältere GC Version gelten.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mir fällt gerade auf, dass in gnc-docbookx.dtd die Entitäten manrevision und date noch nicht aktualisiert sind.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Macht John während des Release-prozesses: https://wiki.gnucash.org/wiki/Documentation_Release_Process#Checks_and_Updates.
Aber wenn du da so etwas bauen willst wie in den Programm-Nieghtlies laß dich nicht bremsen. ;-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ich finde die Angabe der Versionsnummer hier irgendwie unglücklich, da die anderen Kapitel in dieser Datei nicht aktualisiert wurden und ggf. nur für eine bestimmte ältere GC Version gelten.

Mittelfristig möchte ich die Kommentare durch https://tdg.docbook.org/tdg/4.5/blockinfo-x bis https://tdg.docbook.org/tdg/4.5/sectioninfo-x ersetzen. Du kannst sie also auch weiter runterbrechen.

Gedacht waren sie, um nachzusehen, was sich inzwischen in der englischen Version geändert hat. Aber hier arbeiten wir derzeit ja in die andere Richtung.

de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Outdated Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Show resolved Hide resolved
@CWehli CWehli requested a review from fellen August 6, 2023 12:02
@code-gnucash-org code-gnucash-org merged commit 645f0b4 into Gnucash:stable Aug 7, 2023
3 checks passed
fellen
fellen reviewed Aug 7, 2023
View reviewed changes
Copy link
Member

@fellen fellen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Da jetzt nur noch Kosmetischee Änderungen bleiben, habe ich es mal eingecheckt.
Danke !

de/manual/ch_Tools_Assistants.xml Show resolved Hide resolved
de/manual/ch_Tools_Assistants.xml Show resolved Hide resolved
@code-gnucash-org code-gnucash-org temporarily deployed to github-pages August 7, 2023 05:45 — with GitHub Actions Inactive
@code-gnucash-org code-gnucash-org temporarily deployed to github-pages August 8, 2023 05:46 — with GitHub Actions Inactive
@code-gnucash-org code-gnucash-org temporarily deployed to github-pages August 9, 2023 05:45 — with GitHub Actions Inactive
@code-gnucash-org code-gnucash-org temporarily deployed to github-pages August 10, 2023 05:45 — with GitHub Actions Inactive
@code-gnucash-org code-gnucash-org temporarily deployed to github-pages August 11, 2023 05:46 — with GitHub Actions Inactive
@code-gnucash-org code-gnucash-org temporarily deployed to github-pages August 12, 2023 05:45 — with GitHub Actions Inactive
@code-gnucash-org code-gnucash-org temporarily deployed to github-pages August 13, 2023 05:45 — with GitHub Actions Inactive
@code-gnucash-org code-gnucash-org temporarily deployed to github-pages August 14, 2023 05:45 — with GitHub Actions Inactive
@code-gnucash-org code-gnucash-org temporarily deployed to github-pages August 15, 2023 05:46 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fellen fellen fellen left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@CWehli @fellen @code-gnucash-org