[report-utilities] deprecate gnc:commodity-collectorlist-get-merged

this function is unused
Gnucash · Feb 18, 2019 · 51b6cf6 · 51b6cf6
1 parent d7190c0
commit 51b6cf6
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 1 deletion.
diff --git a/gnucash/report/report-system/report-system.scm b/gnucash/report/report-system/report-system.scm
@@ -692,7 +692,7 @@
 (export gnc:make-number-collector)
 (export gnc:make-commodity-collector)
 (export gnc:commodity-collector-get-negated)
-(export gnc:commodity-collectorlist-get-merged)
+(export gnc:commodity-collectorlist-get-merged) ;deprecated
 (export gnc-commodity-collector-commodity-count)
 (export gnc:account-get-balance-at-date)
 (export gnc:account-get-balances-at-dates)

diff --git a/gnucash/report/report-system/report-utilities.scm b/gnucash/report/report-system/report-utilities.scm
@@ -373,6 +373,8 @@ construct gnc:make-gnc-monetary and use gnc:monetary->string instead.")
     negated))
 
 (define (gnc:commodity-collectorlist-get-merged collectorlist)
+  (issue-deprecation-warning
+   "gnc:commodity-collectorlist-get-merged is now deprecated.")
   (let ((merged (gnc:make-commodity-collector)))
     (for-each (lambda (collector) (merged 'merge collector #f)) collectorlist)
     merged))

diff --git a/gnucash/report/report-system/test/test-report-utilities.scm b/gnucash/report/report-system/test/test-report-utilities.scm
@@ -197,6 +197,7 @@
         (collector->list
          (gnc:commodity-collector-get-negated coll-A)))
 
+      ;; deprecated:
       (test-equal "gnc:commodity-collectorlist-get-merged"
         '(("USD" . 25) ("GBP" . 0))
         (collector->list