Fix uninitialized variables (and one leak) in gnome.

Found by clang static analyzer.
Gnucash · Nov 30, 2018 · f526099 · f526099
1 parent 185787d
commit f526099
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/gnucash/gnome/dialog-print-check.c b/gnucash/gnome/dialog-print-check.c
@@ -1414,6 +1414,7 @@ format_read_general_info(const gchar *file,
 static void
 free_check_format(check_format_t *data)
 {
+    g_return_if_fail(data);
     g_free(data->guid);
     g_free(data->filename);
     g_free(data->title);
@@ -1476,7 +1477,7 @@ static void
 read_one_check_directory(PrintCheckDialog *pcd, GtkListStore *store,
                          const gchar *groupname, const gchar *dirname)
 {
-    check_format_t *format, *existing;
+    check_format_t *format = NULL, *existing;
     GDir *dir;
     const gchar *filename;
     GtkTreeIter iter;

diff --git a/gnucash/gnome/dialog-sx-since-last-run.c b/gnucash/gnome/dialog-sx-since-last-run.c
@@ -920,7 +920,7 @@ variable_value_changed_cb(GtkCellRendererText *cell,
                           const gchar *value,
                           GncSxSinceLastRunDialog *dialog)
 {
-    GncSxVariable *var;
+    GncSxVariable *var = NULL;
     GncSxInstance *inst;
     GtkTreeIter tree_iter;
     gnc_numeric parsed_num;

diff --git a/gnucash/gnome/gnc-plugin-page-account-tree.c b/gnucash/gnome/gnc-plugin-page-account-tree.c
@@ -548,6 +548,7 @@ gnc_plugin_page_account_tree_open (Account *account, GtkWindow *win)
     else // we have no account pages, create one
         plugin_page = gnc_plugin_page_account_tree_new ();
 
+    g_return_if_fail(plugin_page);
     window = plugin_page->window;
 
     gnc_main_window_open_page (GNC_MAIN_WINDOW(window), plugin_page);

diff --git a/gnucash/gnome/gnc-split-reg2.c b/gnucash/gnome/gnc-split-reg2.c
@@ -505,7 +505,7 @@ gsr2_redraw_all_cb (GncTreeViewSplitReg *view, gpointer user_data)
     GNCSplitReg2 *gsr = user_data;
     gnc_commodity * commodity;
     GNCPrintAmountInfo print_info;
-    gnc_numeric amount;
+    gnc_numeric amount = gnc_numeric_zero();
     Account *leader;
     gboolean reverse;
     gboolean euro;
@@ -976,6 +976,7 @@ gnc_split_reg2_determine_read_only (GNCSplitReg2 *gsr) //this works
         {
         case PLACEHOLDER_NONE:
             /* stay as false. */
+            g_free (args);
             return;
 
         case PLACEHOLDER_THIS: