Demonstrate fx handling in budget report #1497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jralls
reviewed
Jan 24, 2023
|
Looks fine. |
CrfzdPQM6
force-pushed
the
b_betterCurrencyBudgetReporting
branch
from
788c550
to
d1c0c98
Compare
|
OK, updates incorporated and rebased onto |
|
Please squash the two commits into one. |
jralls
force-pushed
the
b_betterCurrencyBudgetReporting
branch
from
d1c0c98
to
04b0317
Compare
|
Thanks! |
|
Just pushed a squashed commit but I see you've done it faster. Well done! Thanks for merging this, and for all your efforts @jralls and @christopherlam |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This demonstrates a fix to https://bugs.gnucash.org/show_bug.cgi?id=798716
It shows the structure of new functionality to add, since I think the current functions do not allow this.
In essence, for budget reporting, the balance difference of an account should be computed in the local currency first, and then the change should be converted to a parent currency. The results for all sub-accounts are "rolled up" the account hierarchy in the same way as usual, using
gnc_account_foreach_descendant.It will need formatting to match style policies and coding guidelines.