More leaks found #1839
Merged
More leaks found #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopherlam
force-pushed
the
stable-leaks
branch
from
e153903
to
0666d5c
Compare
Previous swigged function- note the `new` is never deleted. Because
they are both const char*, they must be swigged similarly to strings.
static SCM
_wrap_QOF_ID_BOOK_SCM ()
{
#define FUNC_NAME "QOF-ID-BOOK-SCM"
SCM gswig_result;
SWIGUNUSED int gswig_list_p = 0;
QofIdTypeConst result;
result = QOF_ID_BOOK_SCM();
{
QofIdTypeConst * resultptr;
resultptr = new QofIdTypeConst((const QofIdTypeConst &) result);
gswig_result = SWIG_NewPointerObj (resultptr, SWIGTYPE_p_QofIdTypeConst, 1);
}
return gswig_result;
#undef FUNC_NAME
}
After this change:
static SCM
_wrap_QOF_ID_BOOK_SCM ()
{
#define FUNC_NAME "QOF-ID-BOOK-SCM"
SCM gswig_result;
SWIGUNUSED int gswig_list_p = 0;
QofIdType result;
result = QOF_ID_BOOK_SCM();
gswig_result = result ? scm_from_utf8_string (result) : SCM_BOOL_F;
return gswig_result;
#undef FUNC_NAME
}
christopherlam
force-pushed
the
stable-leaks
branch
from
0666d5c
to
5bf9ca0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit msg for reasoning