Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 797648 Redo - Reconciliation - Treat each split independently #713

Merged
merged 3 commits into from
May 3, 2020
Merged

Bug 797648 Redo - Reconciliation - Treat each split independently #713

merged 3 commits into from
May 3, 2020

Conversation

goodvibes2
Copy link
Contributor

@goodvibes2 goodvibes2 commented May 1, 2020

The previous change under this bug which propagated the status
change (reconcile or unreconcile) of any split for the account to
be reconciled (and its subaccounts) in a transaction, to all
splits for the account to be reconciled (and its subaccounts) in
the transaction, is incorrect. Each split needs to be able to be
checked or unchecked independently of any other split in the
transaction.
For instance, if an order delivery was split into 2 parts delivered and billed in different statement periods, the 2 splits need to be reconciled independently.

If anyone needs to reconcile or unreconcile multiple splits in a transaction, they can still do a multi-split selection, then use either the 'Reconcile Selection' or 'Unreconcile Selection' buttons. This is slightly more work, but we need the ability to reconcile splits independently.

See discussion under previous PR #670

@Bob-IT
Copy link
Contributor

Bob-IT commented May 1, 2020

@goodvibes2 Chris is this just a PR to revert what you did in #670 ?
If so can you change the commit message to start "Revert Bug...., @christopherlam did one last week, not sure how he did it but there is 'git revert'

@goodvibes2
Copy link
Contributor Author

Hi Bob-IT,
No, it is not just a revert. It removes the code that was there previously that propagates toggling ( fn gnc_reconcile_view_toggle_children) and also my mods to change the toggling to propagation). I thought about using revert but decided against it, partly because I haven't used it before. I can do a revert, then another commit if you like?

@Bob-IT
Copy link
Contributor

Bob-IT commented May 1, 2020

Chris, I think that is a good idea, it makes it clear what has happened.

The previous change under this bug which propagated the status
change (reconcile or unreconcile) of any split for the account to
be reconciled (and its subaccounts) in a transaction, to all
splits for the account to be reconciled (and its subaccounts) in
the transaction, is incorrect. Each split needs to be able to be
checked or unchecked independently of any other split in the
transaction.
@goodvibes2
Copy link
Contributor Author

Hi @Bob-IT, I have reverted my previous changes and now the last commit is only the changes from before I started.

@code-gnucash-org code-gnucash-org merged commit 2fae14c into Gnucash:maint May 3, 2020
@Bob-IT
Copy link
Contributor

Bob-IT commented May 3, 2020

Thank you.

@goodvibes2 goodvibes2 deleted the bug797648Rec-2 branch June 25, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants