Replace Simple JSON with Gson #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simple-JSON was throwing NoClassDefError at runtime when attempting to parse the RCov JSON file - this looks to be because maven wasn't bundling it as a dependancy for whatever reason. Replacing with Gson seems to have fixed the issue.
|
Great job with this PR! I pulled down the code and it builds great. We should have time tomorrow to test it out and then we'll accept it 😄 |
|
Any ETA on merging this into master? The current baseline is still experiencing the problem and this fix took care of it nicely (its working great for us). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple-JSON was throwing NoClassDefError at runtime when attempting to parse
the RCov JSON file - this looks to be because maven wasn't bundling it as a
dependancy for whatever reason. Replacing with Gson seems to have fixed the
issue.
references issue #8