Added the ability to override RamlNavigatorFactory constants from a child class.

[estelsmith]

It's nice to have the ability to override where the api.raml file is located. By using late static binding, users can extend the RamlNavigatorFactory and update constants, pointing api.raml to a bundle-specific configuration rather than forcing users to place the file in the app/config directory.

Example:

namespace ApiBundle\Factory;

use GoIntegro\Bundle\HateoasBundle\DependencyInjection\Factory\RamlNavigatorFactory as BaseNavigatorFactory;

class RamlNavigatorFactory extends BaseNavigatorFactory
{
    const RAML_DOC_PATH = '/../src/ApiBundle/Resources/config/api.raml';
    const ERROR_PARAM_TYPE = 'The "api.raml" file was not found!';
}

Ideally, the path to the api.raml file would be configurable via config.yml, rather than having to add compiler passes that change service definitions to custom implementations.

[skqr]

Hi, @estelsmith! Thanks for taking the time to contribute.

I'm kinda thinking that that's already possible by overriding the factory service, although I might be wrong.

@acmenna is this possible already, or am I tripping balls?

[estelsmith]

That's what I'm doing is overriding the factory service. However, currently I need to override the service and not only update the constant, but also override __construct() and createNavigator() methods using the exact same functionality provided in the base. An example of what I'm doing is https://github.com/estelsmith/hateoas-test/blob/master/src/ApiBundle/Factory/RamlNavigatorFactory.php.

None of this overridden code is required if RamlNavigatorFactory uses late static binding instead of self when referencing the constants.

[estelsmith]

@skqr I think I just realized a potential source of confusion. I just want to clarify that I was not looking for the ability to override the service, which already exists. I was looking for the ability to change the constants in the overridden service, then have the original code utilize the updated constants without having to also override the class methods as well.

[estelsmith]

@skqr @acmenna Can this pull request be accepted?

[acmenna]

@estelsmith thank you.